-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Use expect for lint warnings #15625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expect for lint warnings #15625
Conversation
Some changes occurred in clippy_lints/src/doc cc @notriddle |
aa5d95e
to
7b687ee
Compare
This comment has been minimized.
This comment has been minimized.
7b687ee
to
1cf40bb
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does seem like a solid improvement (especially since this allows removing some #[allow]
s), though one comment on enabling the lint on the codebase. Apart from that lgtm
1cf40bb
to
3f57021
Compare
This comment has been minimized.
This comment has been minimized.
3f57021
to
3bb2fdf
Compare
This comment has been minimized.
This comment has been minimized.
This is ready to go. |
Since the only change requested by @y21 before merging has been done, I'll merge this to avoid having to rebase frequently. |
Dogfood needs to be fixed due to recent changes in |
Reminder, once the PR becomes ready for a review, use |
3bb2fdf
to
5318883
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
@rustbot ready |
Fixed the constant thing. Also changed another |
changelog:none